If the addin cannot be properly loaded, just skip the file.#11
Merged
anshivashankar merged 2 commits intomasterfrom May 15, 2023
Merged
If the addin cannot be properly loaded, just skip the file.#11anshivashankar merged 2 commits intomasterfrom
anshivashankar merged 2 commits intomasterfrom
Conversation
zhuliice
reviewed
May 15, 2023
| catch | ||
| { | ||
| // if the XML is malformed or not parse-able, just continue | ||
| continue; |
Collaborator
There was a problem hiding this comment.
Does it ever happen that *.addin is malformed?
Instead of ignoring the error in silence, we'd better at least pop out an error message by "MessageBox.Show"(for example).
Collaborator
Author
There was a problem hiding this comment.
It seems like it does, see issue filed last year here: #8
We also see some issues on stackoverflow: https://stackoverflow.com/questions/76132803/forge-design-automation-debug-revit-plugin-locally-tutorial-not-working
(however, we can certainly throw an message)
zhuliice
approved these changes
May 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.